-
Notifications
You must be signed in to change notification settings - Fork 379
Properly consider the border thickness on the annotations' events #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
0ada4af
Properly consider the border thickness on the annotations' events
stockiNail c3457a8
adds test cases on label annotation
stockiNail 9c45201
changes line label inRange calculation
stockiNail 6da4d1f
uses testEvents to test events considering border and not
stockiNail 952476d
removes decomposition of not used properties
stockiNail cc81827
reduces similar code on events test file
stockiNail 7aa9a91
Merge remote-tracking branch 'origin/master' into eventsAndThickness
stockiNail 97d77e7
refactoring of event test file
stockiNail 3a406f2
applies tests one pixel in the other direction not triggering the hooks
stockiNail 87bb9db
sets borderWidth:0
stockiNail f7d4e6b
adds additional common tests
stockiNail 93dd210
optimizes the invocation of common code among the specs
stockiNail 921b542
adds test cases removing borderWidth at runtime
stockiNail 875d317
Merge remote-tracking branch 'origin/master' into eventsAndThickness
stockiNail 3022e73
reduces test cases
stockiNail 854fca1
refactoring of events test cases
stockiNail 6f147a9
Merge remote-tracking branch 'origin/master' into eventsAndThickness
stockiNail dcda29f
remove comment
stockiNail d411d95
fixes ellipse spec test case
stockiNail 8673e25
fixes annotation type
stockiNail 183192d
fixes polygon event test case
stockiNail 520ef65
adds test cases, removed before cleaning up
stockiNail eb6c36c
removes useless test case because internal
stockiNail 68de971
adds test cases for an undefined borderwidth
stockiNail f4cfdca
remove useless options
stockiNail File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.