Skip to content

Update async-std and stop-token dependencies, migrate to stable channels #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2021
Merged

Update async-std and stop-token dependencies, migrate to stable channels #41

merged 3 commits into from
Feb 14, 2021

Conversation

seijikun
Copy link
Contributor

@seijikun seijikun commented Feb 7, 2021

Updated async-std and stop-token dependencies.
The new async-std stabilized the channel api, and relocated them, so I migrated from async_std::sync to the new namespace async_std::channel.

The send() methods in the new stable channel api now returns Results. I didn't want to assume what to best do with these, so I added TODOs.

@hpk42 hpk42 requested a review from dignifiedquire February 7, 2021 13:24
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's clean up the TODOs and then it's good to merge i think.

@flub flub merged commit f4e7651 into chatmail:master Feb 14, 2021
@yancyribbens
Copy link

Will this fix be available on Crates.io? Currently 0.4.1 on crates.io fails to compile, and so cargo must be pointed to this git repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants