dc_set_config("selfavatar", "/path/to/image.png") incorrect on windows

[ralphtheninja]

Background: I do dc_set_config("selfavatar", "/some/path/avatar.png") and when I get the value back via dc_get_config("selfavatar") it points to a path in the blob dir that contains a forward slash e.g.: (from integration tests in node bindings)

not ok 13 selfAvatar correct
  ---
    operator: equal
    expected: |-
      'C:\\Users\\User\\AppData\\Local\\Temp\\fb85cb643f6173c334492ed417daff90\\db.sqlite-blobs\\avatar.png'
    actual: |-
      'C:\\Users\\User\\AppData\\Local\\Temp\\fb85cb643f6173c334492ed417daff90\\db.sqlite-blobs/avatar.png'
    at: DeltaChat.dc.once (C:\Users\User\src\deltachat\deltachat-node\test\integration.js:62:7)
    stack: |-
      Error: selfAvatar correct
          at Test.assert [as _assert] (C:\Users\User\src\deltachat\deltachat-node\node_modules\tape\lib\test.js:226:54)
          at Test.bound [as _assert] (C:\Users\User\src\deltachat\deltachat-node\node_modules\tape\lib\test.js:77:32)
          at Test.equal (C:\Users\User\src\deltachat\deltachat-node\node_modules\tape\lib\test.js:386:10)
          at Test.bound [as is] (C:\Users\User\src\deltachat\deltachat-node\node_modules\tape\lib\test.js:77:32)
          at DeltaChat.dc.once (C:\Users\User\src\deltachat\deltachat-node\test\integration.js:62:7)
          at Object.onceWrapper (events.js:286:20)
          at DeltaChat.emit (events.js:198:13)
          at DeltaChat.ready (C:\Users\User\src\deltachat\deltachat-node\lib\deltachat.js:89:12)
          at Object.onceWrapper (events.js:286:20)
          at DeltaChat.emit (events.js:198:13)

dc_get_config() in turn calls dc_get_abs_path() which contains the bug (guessing).

[ralphtheninja]

We should first write a failing test for this.

@dignifiedquire Question is how to write it for multiple platforms. Can you have different assert_eq!() depending on the platform?

[dignifiedquire]

why should this test be different on different platforms? it should use os independent path separators and abstractions in rust.

[ralphtheninja]

That makes more sense obviously. Where do I start looking?

[dignifiedquire]

https://doc.rust-lang.org/std/path/struct.Path.html

…

On 7. Jun 2019, 19:30 +0200, Lars-Magnus Skog ***@***.***>, wrote: That makes more sense obviously. Where do I start looking? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[dignifiedquire]

https://doc.rust-lang.org/std/path/index.html

…

On 7. Jun 2019, 19:30 +0200, Lars-Magnus Skog ***@***.***>, wrote: That makes more sense obviously. Where do I start looking? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[ralphtheninja]

Actually, it seems dc_get_abs_path() is correct. It's how it's used by the core that's incorrect.

[r10s]

just some background: dc_set_config(context, "selfavatar", "/gallery/image.jpg") does not only save the given string in the database. it creates a physical copy of the given image-file to the blob-directory and stores that as $BLOBDIR/image.jpg.

when calling dc_set_config(context, "selfavatar"), $BLOBDIR is expanded to the current blob directory automatically so that the ui should be able to use all paths directly. return value may be eg /home/user/somemailbox.db-blobs/image.jpg.

[hpk42]

See also the tentatively closed #135

[hpk42]

could you retry if this is still an issue on master? there are a lot of changes/improvements that might have resolved it.

[hpk42]

k, closing as it's likely fixed and nobody gets back.