test: add failing test for selfavatar #135
Conversation
| } | ||
|
|
||
| 0 | ||
| pub unsafe fn dc_is_blobdir_path(context: &Context, path: *const libc::c_char) -> bool { |
There was a problem hiding this comment.
Nothing to do with these tests, but it came in my way and was easy to fix.
| let image_c = CString::new(image_path_2.to_str().unwrap()).unwrap(); | ||
| let abs_path = unsafe { dc_get_abs_path(&ctx.ctx, image_c.as_ptr()) }; | ||
|
|
||
| assert_eq!(to_string(abs_path), image_path.to_str().unwrap()); |
There was a problem hiding this comment.
This test works on windows and *nix.
| let mut image_path = PathBuf::from(to_string(blobdir_c)); | ||
| image_path.push("delta-logo.png"); | ||
|
|
||
| assert_eq!(to_string(selfavatar), image_path.to_str().unwrap()); |
There was a problem hiding this comment.
This should fail on windows.
There was a problem hiding this comment.
no totally sure, but dc_set_config() tries to copy the given file physically to the blob directory. i assume the file described by logo_path_c normally does not exist? maybe the behavior of copying unexistent files is slightly different at some level (dc_set_config() uses the source file when copying failed)
to have a reliable test, maybe ensure that the given file exists before calling dc_get_config()? no need to be a valid image, an empty file should do the job.
There was a problem hiding this comment.
to have a reliable test, maybe ensure that the given file exists before calling dc_get_config()? no need to be a valid image, an empty file should do the job.
That's what the test is doing, logo_path_c always points to an existing file in the fixtures folder.
|
Nevermind, I was using |
|
had a look at the logic of calling dc_is_blobdir_path(), lgtm |
|
Simplest fix would be to normalize the path here https://github.com/deltachat/deltachat-core-rust/blob/master/src/context.rs#L485 |
| @@ -966,6 +966,7 @@ fn test_selfavatar_config() { | |||
| logo_path.push("tests"); | |||
| logo_path.push("fixtures"); | |||
| logo_path.push("delta-logo.png"); | |||
| assert!(logo_path.as_path().exists()); | |||
There was a problem hiding this comment.
This is only asserting that we do have a real file in the test.
| @@ -987,6 +988,7 @@ fn test_selfavatar_config() { | |||
| let mut image_path = PathBuf::from(to_string(blobdir_c)); | |||
| image_path.push("delta-logo.png"); | |||
|
|
|||
| assert!(image_path.as_path().exists()); | |||
There was a problem hiding this comment.
The resulting file in the blobdir should exist.
There was a problem hiding this comment.
It seems windows manages to copy the file to the blobdir at least. This is good to know.
|
Side note: I've tested this on desktop and it's not a problem there since the browser doesn't care about mixed |
|
retiring this PR as there is no activity but made a note at #116 that this PR exists. |
No description provided.