Rename to_str() -> as_str() to match stdlib naming convention #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function does a cast and does not create a new objects. The stdlib convention is to use to_*() for functions which return new objects and as_*() for functions which keep referring to the same data but using a different type. Follow that convention.
|
you are entirely right, thank you |
dignifiedquire
approved these changes
Jun 7, 2019
ralphtheninja
approved these changes
Jun 7, 2019
|
What's that |
jptyrkko
pushed a commit
to open-xchange/deltachat-core-rust
that referenced
this pull request
Aug 19, 2019
This update addresses the tickets chatmail#133 and chatmail#134. The mode of the program is now controlled by a new configuration parameter ChatMode, whose value "off" forces the program to use the "Gr." legacy prefix, and "on", which outputs the "chat$group." prefix. For reading the header both prefixes are recognized and accepted. Function dc_create_outgoing_rfc724_mid has now a new parameter "context" to allow reading the configuration within the function. The new convention has been reflected on the tests at the end of dc_tools.rs. In the source the modified code sections are marked by the date and the committer name "Juha-Petri Tyrkkö".
phranck
pushed a commit
to open-xchange/deltachat-core-rust
that referenced
this pull request
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function does a cast and does not create a new objects. The
stdlib convention is to use to_() for functions which return new
objects and as_() for functions which keep referring to the same data
but using a different type. Follow that convention.