feat: Add utility to convert OsStr to CString #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is approach seems acceptable in the context of deltachat, it should work correctly on unix and on Windows requires paths to be valid utf-8.
- Adds an OsStrExt impl for Path directly, a little more convenience. - Fix the windows code to actually use the right function name. Test the impl function on unix too since that was the point of having it implemented in a separate function to begin with. - Improve the docs, do hyperlinks a bit better.
Having your compiler in the cloud is just painful.
When PRs are made from forks the passwords are unavailable. We don't want CI to fail because of this.
This means any type with implements this trait will get this implementation, thus covering both OsStr and Path instead of having duplicate implementations for those like before.
ralphtheninja
changed the title
|
@flub Please feel free to push directly to the main repo when making PRs. Makes it a little bit easier for others to tweak in case you're not around. I really want this change in 😉 |
|
Fair enough, I always feel weird using privileges others don't have though. And it did surface the fact that CI had a bug for PRs from other repos :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flubs awesome string conversion + fmt.