Add utility to convert OsStr to CString

[flub]

Several iterations later I think this is a fairly reasonable style and and api for this. Let me know what you think.

[flub]

Btw, I didn't know how to produce an OsString with invalid unicode in for a test so didn't include such a test. If you know how to do that I'd be happy to add such a test.

[dignifiedquire]

btw, I didn't know how to produce an OsString with invalid unicode in for a test

Did you try casting raw bytes to one?

[flub]

Tried this:

let some_str = std::ffi::OsString::from(b"foo\xC0bar");
     |                        ^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::AsRef<std::ffi::OsStr>` is not implemented for `[u8; 7]`

but it doesn't like that as you can see, did you mean something else with casting?

[flub]

Any way to tell circleci to not run the upload_doc_wheels job for a PR from a different repo? My quick hack would be to just change the early exit in the script to 0 so it succeeds but I'm not sure that's desired. /cc @hpk42

[hpk42]

@flub i think one could skip the whole upload_test_wheels thing if "DEVPI_LOGIN" is not defined. i am doing my branches in-repo so the problem didn't occur to me yet.

[flub]

@hpk42 so you're happy with doing this in the script rather that the circleci config?

[hpk42]

@flub no preference, was just pointing out a possibility. i guess it'd be better to only run the script/step on the merged branch, not the branch itself.

[flub]

ping, i reckon this is ready

[flub]

Oh, maybe the trait should use AsRef<OsStr> and than I'd not need the impl for Path. I think that's nicer. I'll refactor that way.

[flub]

Scratch that, that doesn't seem to work. I'll stick with this as is.

[hpk42]

hum, there is no code yet using these utils or am i missing something? If so, wouldn't it make sense to have a few files use the utils and see that it actually fits?

[flub]

Perhaps, I'm actually factoring this out of a much larger change to make reviewing more sane. But it's true that said change is not in a PR yet. Is there a way to chain PRs in github so I can both these at the same time? If so I'm happy to leave this lying around till the PR that uses it is ready too.

[ralphtheninja]

Is there a way to chain PRs in github so I can both these at the same time?

Yes there is. Just make a new branch based on top of this one and make a PR with that. When merging the second PR, this PR will be closed automatically. But you might as well just add some commits on top of this branch.

[dignifiedquire]

just some formatting issues, other than looks good to me

[ralphtheninja]

Made a new PR with format changes here #136