feat(webxdc): add unique IDs to status updates sent outside #5048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
link2xt
force-pushed
the
link2xt/webxdc-update-deduplication
branch
from
8646aad to
15a132a
Compare
link2xt
changed the title
This allows for deduplication if status updates are sent over multiple transports.
link2xt
force-pushed
the
link2xt/webxdc-update-deduplication
branch
from
15a132a to
52144cf
Compare
Septias
approved these changes
Nov 26, 2023
link2xt
commented
Nov 27, 2023
src/debug_logging.rs
Outdated
| status_update_serial: serial, | ||
| }); | ||
| if let Some(serial) = serial { | ||
| context.emit_event(EventType::WebxdcStatusUpdate { |
There was a problem hiding this comment.
change_logging_webxdc fails randomly with the "Database is locked" error now.
But I wonder how it ever worked, this emits a "webxdc status update" event which then itself gets logged as a webxdc update.
This ensures old version of Delta Chat will be fine with a new "uid" field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for deduplication
if status updates are sent over multiple transports.
close #5042