Skip to content

checked-c-convert: some return types mangled #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AnnaKornfeldSimpson opened this issue Jul 11, 2018 · 2 comments
Closed

checked-c-convert: some return types mangled #520

AnnaKornfeldSimpson opened this issue Jul 11, 2018 · 2 comments
Assignees
Labels
bug This labels issues that are bugs.

Comments

@AnnaKornfeldSimpson
Copy link
Collaborator

For a small number of functions <return_type> * function_name… gets replaced with `<return_type>function_name. No space between the type and the function name, and the * has just been swallowed.

Example: parson.checked.c:126
Original code: parson.c:126
Error Produced: talks about the itype on the return annotation. The accompanying warning is actually a little more specific as to the problem.

To use this test case:

  • Clone https://github.com/AnnaKornfeldSimpson/parson
  • Check out the snapshotWeUse branch
  • make test to build the original code. make testchecked to build with the copies produced by checked-c-convert.
  • convert.sh runs checked-c-convert on the original code and outputs to *checked* files. If you re-run it, also edit parson.checked.c to use parson.checked.h. convert.sh may need modifications to run in Windows.
  • Compiler errors can be compared with compilerErrors.txt (produced on a Ubuntu system, not sure if it will perfectly match in Windows)
@awruef
Copy link
Collaborator

awruef commented Jul 16, 2018

Note to myself, I bet this is related to #524.

@awruef awruef self-assigned this Jul 16, 2018
@dtarditi dtarditi added the bug This labels issues that are bugs. label Nov 6, 2018
@dtarditi
Copy link
Member

dtarditi commented Sep 2, 2019

The convert tool has been mostly rewritten (see PR #642). Please reopen this issue if it still exists.

@dtarditi dtarditi closed this as completed Sep 2, 2019
sulekhark pushed a commit that referenced this issue Jul 8, 2021
It is buggy, and we no longer need it now that we're confident in
implicit checked header inclusion.

clang/tools/3c/utils/{,port_tools/}README.md are significantly out of
date, but that can be addressed separately.

Addresses #520.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This labels issues that are bugs.
Projects
None yet
Development

No branches or pull requests

3 participants