Get variable and constant from upper bounds#1135
Merged
Merged
Conversation
added 30 commits
July 7, 2021 15:53
…dths methods from BaseRange and call utility methods instead
… already in the output form
…into plus-one-minus-one-bounds-widening
…ns::CompareNormalizedBounds
…into normalize-multiple-bounds-widening
…into get-variable-and-constant
This was referenced Jan 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
GetVariableAndConstantmethod toNormalizeUtilin order to compare two upper bound expressions. This enables the bounds checker to validate bounds that have been widened multiple times.For example:
GetVariableAndConstantseparates an input expressionEinto a pointer-typed expressionE1and an integer constantCfor as long as possible. It adds up each constant found this way and, if the result does not overflow, sets the out parameterConstantto the result of adding up all the constants and sets the out parameterVariableto the final pointer-typed subexpression ofE.