Fix Return value of ParseRelativeBoundsForDecl not being used (#282) #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dc#282) .According to the return value of ParseRelativeBoundsForDecl, it generates "invalid rel_align or rel_align_value" error message.
|
I think it is ready for review. Thanks. |
dtarditi
reviewed
Apr 25, 2017
lib/Parse/ParseExpr.cpp
Outdated
| @@ -2841,7 +2841,10 @@ ExprResult Parser::ParseBoundsExpressionOrInteropType(const Declarator &D, | |||
|
|
|||
| TempTok = Tok; | |||
| if (StartsRelativeBoundsClause(Tok)) | |||
| ParseRelativeBoundsClauseForDecl(Result); | |||
| if (ParseRelativeBoundsClauseForDecl(Result)) { | |||
| Diag(Tok, diag::err_invalid_relative_bounds_clause); | |||
There was a problem hiding this comment.
You don't need to issue an error message here. I believe ParseRelativeBoundsClauseForDecl should have issued an error message if necessary. This will just confuse the programmer who sees the message. It is sufficient to just return an ExprError().
|
I think it is ready for further review. Thanks always! |
dopelsunce
pushed a commit
to dopelsunce/checkedc-clang
that referenced
this pull request
Sep 28, 2020
Finalize version 0.7.1. of the specification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.According to the return value of ParseRelativeBoundsForDecl, it generates "invalid rel_align or rel_align_value" error message.