Skip to content

Fix up bugs related to #302 #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2017
Merged

Fix up bugs related to #302 #303

merged 2 commits into from
May 17, 2017

Conversation

wonsubkim
Copy link
Collaborator

  + if function return type is unchecked pointer type with bounds-safe interface, it is not checked properly
  For function declaration, it SHOULD consider its return type not function type itself
@lenary
Copy link
Collaborator

lenary commented May 17, 2017

This is no longer causing issues in the test suite with calloc, and the change seems reasonable, but I want david to approve it before you merge it.

  + handle else case for CheckedDecl in checked scope
  + modified implicit cast expression for call expression
  For call expression, DO NOT generate implicit cast expression for checked pointer type
  + modified code generation of EmitCallArgs
  I have also handled unchecked pointer type with bounds safe interface not also interop type
Copy link
Member

@dtarditi dtarditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, except for the change to function-to-pointer decay. I believe that change is not what we want. I've opened issue #304 to revisit that. Thank you for the quick turnaround.

@dtarditi dtarditi merged commit 55d628a into checkedc:master May 17, 2017
dopelsunce pushed a commit to dopelsunce/checkedc-clang that referenced this pull request Sep 28, 2020
…kedc#303)

Added tests for polymorphic bounds interface functions.
sulekhark pushed a commit that referenced this pull request Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants