Conversation
The children() method for iterating over chidren of AST cast expressions was incorrectly including compiler-generated bounds expressions. Child AST nodes should be nodes that appear in the source program and additional information shouldn't be treated as child nodes. There were complex IR invariants about when a bounds expression stored within a cast expression was child AST node or not. This change fixes the bug and simplifies the AST invariants. This fixes issue #526. for cast expressions, there is now one entry for bounds expressions declared as part of the program. There are separate nodes for normalized bounds and inferred bounds. Testing: - Added a new regression test case for the failing case. - Passes existing Checked C and clang Checked C tests.
Prabhuk
approved these changes
Jul 31, 2018
Prabhuk
left a comment
Prabhuk
left a comment
Collaborator
There was a problem hiding this comment.
The changes look good. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The children() method for iterating over chidren of AST cast expressions
was incorrectly including compiler-generated bounds expressions. Child AST
nodes should be nodes that appear in the source program and additional
information shouldn't be treated as child nodes. There were
complex IR invariants about when a bounds expression stored within a cast
expression was child AST node or not.
This change fixes the bug and simplifies the AST invariants. This fixes
issue #526. for cast expressions, there is now one entry for bounds expressions
declared as part of the program. There are separate nodes for normalized
bounds and inferred bounds.
Testing: