Skip to content

Fix wrong use of assert #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dtarditi merged 1 commit into from
Oct 6, 2018
Merged

Fix wrong use of assert #568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/AST/CanonBounds.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ Lexicographic::CompareDecl(const NamedDecl *D1Arg, const NamedDecl *D2Arg) const
return Result::Equal;

if (!D1 || !D2) {
assert("unexpected cast failure");
assert(false && "unexpected cast failure");
return Result::LessThan;
}

Expand Down
2 changes: 1 addition & 1 deletion lib/Sema/CheckedCInterop.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class TransformFunctionTypeToChecked :
// Assert on trailing returning type for now, instead of handling them.
// That's a C++ feature that we cannot test right now.
if (T->hasTrailingReturn()) {
assert("Unexpected trailing return type for Checked C");
assert(false && "Unexpected trailing return type for Checked C");
return QualType();
}

Expand Down