[checked-c-convert] Minor fixes to the checked-c-convert #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows for all statements to bubble up through the analysis engine, not just declaration statements.
Merging into master after debugging NT issue.
Debugging nt
In certain cases, the file/line/column information stored in the
PersistentSourceLocation class is not enough to uniquely disambiguate
definitions from one another. To support these cases, this commit
adds a "reproducible" AST node identifier as a distinguishing feature.
According to the "Clang Front End for LLVM Developers' List":
"If you want something that's more stable across runs (pointers
would obviously change every time), you can have a look at the
getID() method in various AST nodes, which produces an integer
that doesn't change across runs but does change across host
machines."
Which should work fine for our purposes.
This fixes #18.
This brings dev-fixes up-to-date with dev in preparation for submitting a new PR to Microsoft.
Brings upstream changes into the PLUM fork.
Bring in updates from Microsoft to allow for a clean PR.
This should address the regression reported by @Machiry and discovered by @hasantouma, and resolve #18.
Brings changes from Microsoft's main branch into our development branch.
Brings changes from our main development branch to prepare for a PR.
dtarditi
reviewed
Sep 19, 2019
mgrang
pushed a commit
that referenced
this pull request
Sep 26, 2019
Cherry-picked from commit ba778c3 Author: Machiry Aravind Kumar <[email protected]> Commit: David Tarditi <[email protected]> [checked-c-convert] Minor fixes to the checked-c-convert (#679) - Add knowledge of calloc and realloc as allocator functions. - Add initializers for variables retyped as checked pointers. - Add initializers for structure variables containing members that have been retyped as checked pointers. - Avoid deletion of variable arguments.
mgrang
pushed a commit
that referenced
this pull request
Sep 27, 2019
Cherry-picked from commit ba778c3 - Add knowledge of calloc and realloc as allocator functions. - Add initializers for variables retyped as checked pointers. - Add initializers for structure variables containing members that have been retyped as checked pointers. - Avoid deletion of variable arguments.
mgrang
pushed a commit
that referenced
this pull request
Sep 27, 2019
Cherry-picked from commit ba778c3 - Add knowledge of calloc and realloc as allocator functions. - Add initializers for variables retyped as checked pointers. - Add initializers for structure variables containing members that have been retyped as checked pointers. - Avoid deletion of variable arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes various issues related to checked-c-convert.
Specifically, the following issues have been fixed:
Although, the number of commits looks more (because of rebasing our branch with
master), the effective changes are very less.