Skip to content

Conversation

@kkjeer
Copy link
Contributor

@kkjeer kkjeer commented Nov 5, 2019

In checking for memory access violations for a bounds cast expression bounds_cast(e), use a temporary binding of e for the access base. This fixes a regression in memory access detection introduced in #694 (described in #695).

Testing:

  • Re-enabled temporarily disabled out-of-bounds warning in checkedc/391.
  • Passed local testing on Windows.
  • Passed automated testing on Windows and Linux.

@kkjeer kkjeer requested review from dtarditi and mgrang November 5, 2019 00:17
Copy link
Member

@dtarditi dtarditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants