Skip to content

CheckedCRewriter unit tests fail after CConv changes #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
secure-sw-dev-bot opened this issue Jan 16, 2022 · 2 comments
Closed

CheckedCRewriter unit tests fail after CConv changes #847

secure-sw-dev-bot opened this issue Jan 16, 2022 · 2 comments

Comments

@secure-sw-dev-bot
Copy link

This issue was copied from checkedc/checkedc-clang#851


After checkedc/checkedc-clang#837 merged we see the following three unit tests failing intermittently only on Windows:

- test/CheckedCRewriter/global.c
- test/CheckedCRewriter/simple_locals.c
- test/CheckedCRewriter/basic_checks.c

At least test/CheckedCRewriter/global.c seems to fail always when run manually on Windows.

$ "cconv-standalone" "clang\test\CheckedCRewriter\global.c" "--"
# command stderr:
Assertion failed: getPiece(StartPiece).size() > NumBytes, file clang\lib\Rewrite\RewriteRope.cpp, line 380

In order to unblock our failing ADO builds we need to disable the above three tests. We can enable them when we have these fixed.

@secure-sw-dev-bot
Copy link
Author

Comment from @mgrang:

PR to disable tests: checkedc/checkedc-clang#854

@secure-sw-dev-bot
Copy link
Author

Comment from @mgrang:

I see that these tests have been enabled by the 3C team and they are passing. I will go ahead and close this bug as it is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant