Skip to content

CheckedCRewriter unit tests fail after CConv changes #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgrang opened this issue Jun 10, 2020 · 2 comments
Closed

CheckedCRewriter unit tests fail after CConv changes #851

mgrang opened this issue Jun 10, 2020 · 2 comments
Assignees
@mgrang

Comments

@mgrang
Copy link

mgrang commented Jun 10, 2020 •
edited
Loading

After #837 merged we see the following three unit tests failing intermittently only on Windows:

- test/CheckedCRewriter/global.c
- test/CheckedCRewriter/simple_locals.c
- test/CheckedCRewriter/basic_checks.c

At least test/CheckedCRewriter/global.c seems to fail always when run manually on Windows.

$ "cconv-standalone" "clang\test\CheckedCRewriter\global.c" "--"
# command stderr:
Assertion failed: getPiece(StartPiece).size() > NumBytes, file clang\lib\Rewrite\RewriteRope.cpp, line 380

In order to unblock our failing ADO builds we need to disable the above three tests. We can enable them when we have these fixed.
@mgrang mgrang added the bug This labels issues that are bugs. label Jun 10, 2020
mgrang pushed a commit that referenced this issue Jun 11, 2020
Disable failing unit tests
582828d 
After #837 merged we see the following three unit tests failing intermittently
only on Windows:

test/CheckedCRewriter/global.c
test/CheckedCRewriter/simple_locals.c
test/CheckedCRewriter/basic_checks.c

In order to unblock our failing ADO builds we are disabling these three tests.
We can enable them when we have these fixed.

See issue #851
@mgrang mgrang mentioned this issue Jun 11, 2020
Merged
@mgrang
Copy link
Author

mgrang commented Jun 11, 2020

PR to disable tests: #854

@mgrang mgrang mentioned this issue Jun 11, 2020
Merged
mgrang pushed a commit that referenced this issue Jun 11, 2020
Disable failing unit tests (#854)
bee7360 
After #837 merged we see the following three unit tests failing intermittently
only on Windows:

test/CheckedCRewriter/global.c
test/CheckedCRewriter/simple_locals.c
test/CheckedCRewriter/basic_checks.c

In order to unblock our failing ADO builds we are disabling these three tests.
We can enable them when we have these fixed.

See issue #851
@sulekhark sulekhark removed the bug This labels issues that are bugs. label Jan 27, 2021
@mgrang
Copy link
Author

mgrang commented Jan 28, 2021

I see that these tests have been enabled by the 3C team and they are passing. I will go ahead and close this bug as it is no longer relevant.

@mgrang mgrang closed this as completed Jan 28, 2021
@mgrang mgrang self-assigned this Jan 28, 2021
This was referenced Jan 16, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgrang mgrang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgrang @sulekhark