-
-
Notifications
You must be signed in to change notification settings - Fork 175
Persist input prompt drafts on cancel/escape #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7231042
feat: persist input prompt drafts on cancel
chhoumann 37c09dc
feat: add input prompt draft setting
chhoumann bcc1012
fix: move settings defaults to shared module
chhoumann fe81e69
refactor: share input prompt draft handling
chhoumann 30bf140
Merge origin/master
chhoumann dbe3702
fix: capture prompt input before modal teardown
chhoumann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| export type InputPromptDraftKind = "single" | "multi"; | ||
|
|
||
| export interface InputPromptDraftKey { | ||
| kind: InputPromptDraftKind; | ||
| header: string; | ||
| placeholder?: string; | ||
| linkSourcePath?: string; | ||
| } | ||
|
|
||
| interface DraftEntry { | ||
| value: string; | ||
| timestamp: number; | ||
| } | ||
|
|
||
| export class InputPromptDraftStore { | ||
| private static instance: InputPromptDraftStore; | ||
| private drafts: Map<string, DraftEntry> = new Map(); | ||
| private readonly MAX_ENTRIES = 100; | ||
|
|
||
| static getInstance(): InputPromptDraftStore { | ||
| if (!InputPromptDraftStore.instance) { | ||
| InputPromptDraftStore.instance = new InputPromptDraftStore(); | ||
| } | ||
| return InputPromptDraftStore.instance; | ||
| } | ||
|
|
||
| private constructor() { | ||
| // Session-only store | ||
| } | ||
|
|
||
| makeKey(key: InputPromptDraftKey): string { | ||
| return JSON.stringify({ | ||
| v: 1, | ||
| kind: key.kind, | ||
| header: key.header, | ||
| placeholder: key.placeholder ?? "", | ||
| linkSourcePath: key.linkSourcePath ?? "", | ||
| }); | ||
| } | ||
|
|
||
| get(key: string): string | undefined { | ||
| return this.drafts.get(key)?.value; | ||
| } | ||
|
|
||
| set(key: string, value: string): void { | ||
| if (this.drafts.size >= this.MAX_ENTRIES && !this.drafts.has(key)) { | ||
| this.evictOldest(1); | ||
| } | ||
|
|
||
| this.drafts.set(key, { | ||
| value, | ||
| timestamp: Date.now(), | ||
| }); | ||
| } | ||
|
|
||
| clear(key: string): void { | ||
| this.drafts.delete(key); | ||
| } | ||
|
|
||
| clearAll(): void { | ||
| this.drafts.clear(); | ||
| } | ||
|
|
||
| private evictOldest(count: number): void { | ||
| const entries = Array.from(this.drafts.entries()) | ||
| .sort(([, a], [, b]) => a.timestamp - b.timestamp) | ||
| .slice(0, count); | ||
|
|
||
| for (const [key] of entries) { | ||
| this.drafts.delete(key); | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.