Skip to content

feat: add back class to choice suggester#1047

Merged
chhoumann merged 1 commit intomasterfrom
517
Dec 19, 2025
Merged

feat: add back class to choice suggester#1047
chhoumann merged 1 commit intomasterfrom
517

Conversation

@chhoumann
Copy link
Copy Markdown
Owner

@chhoumann chhoumann commented Dec 19, 2025 •
edited
Loading

Summary

  • add a dedicated CSS class for the "← Back" suggestion item
  • reuse the back label constant for rendering and navigation

Testing

  • bun run build

Closes #517

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
quickadd Ready Ready Preview Dec 19, 2025 5:39pm

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 19, 2025 •
edited
Loading

Walkthrough

This PR refactors the back button in multi-choice suggestions by introducing a module-level constant for the back label text and applying a specific CSS class (quickadd-choice-suggestion-back) to enable custom styling of the back item without public API modifications.

Changes

Cohort / File(s) Summary
Back button styling
src/gui/suggesters/choiceSuggester.ts		 Introduces backLabel constant; applies quickadd-choice-suggestion-back CSS class when rendering back items; replaces hard-coded "← Back" strings with the constant throughout multi-choice flow

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify the CSS class name aligns with naming conventions and is correctly applied in the rendering logic
  • Confirm no tests require updates for the new constant or CSS class

Poem

🐰 A rabbit hops with glee,
The back button now styling-free!
With classes bright and constants keen,
CSS dreams can now be seen.
Hop, hop—customization's in the scene! 🎨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding a CSS class to style the back suggestion item in the choice suggester.
Linked Issues check ✅ Passed The pull request fully implements the feature request from issue #517 by adding a dedicated CSS class 'quickadd-choice-suggestion-back' to the back suggestion item.
Out of Scope Changes check ✅ Passed All changes are directly related to implementing the feature in issue #517; no out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 517

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chhoumann chhoumann merged commit 4c8cfe9 into master Dec 19, 2025
4 checks passed
@chhoumann chhoumann deleted the 517 branch December 19, 2025 20:48
@chhoumann chhoumann mentioned this pull request Dec 19, 2025
Closed
github-actions Bot pushed a commit that referenced this pull request Jan 28, 2026
@semantic-release-bot
release(version): Release 2.10.0 [skip ci]
952d13a 
# [2.10.0](2.9.4...2.10.0) (2026-01-28)

### Bug Fixes

* add insert-after blank-line mode ([#1056](#1056)) ([231e908](231e908))
* backfill file opening defaults for legacy choices ([bfffd46](bfffd46))
* default update announcements to major ([#1042](#1042)) ([4e5659b](4e5659b))
* handle template overwrite with case-mismatched paths ([#1049](#1049)) ([0140556](0140556))
* harden suggester display items ([5460657](5460657))
* harden suggester filtering on Android ([4560f22](4560f22)), closes [#1078](#1078)
* normalize leading slashes in capture/template paths ([#1050](#1050)) ([1c7def1](1c7def1))
* normalize unicode in file suggestions ([#1046](#1046)) ([10c0402](10c0402))
* pin obsidian types to 1.11.4 for SecretStorage API ([ddbf6f6](ddbf6f6))
* prefill macro rename input ([#1043](#1043)) ([06c4a25](06c4a25))
* preserve blank lines for insert after ([#1054](#1054)) ([818c036](818c036))
* preserve variables for VALUE templating ([36d43ba](36d43ba))
* reduce bundle size below sync limit ([1e1a632](1e1a632))
* restore compatibility with Templater 2.18.0 ([716f2d9](716f2d9)), closes [#1085](#1085) [#1086](#1086)

### Features

* add back class to choice suggester ([#1047](#1047)) ([4c8cfe9](4c8cfe9))
* add capture selection-as-value controls ([#1055](#1055)) ([250768a](250768a))
* add inline insert-after capture mode ([b2e1ef5](b2e1ef5))
* add macro selection helper ([786b53c](786b53c)), closes [#483](#483)
* add native date picker prompt ([2811c5a](2811c5a))
* add per-token multiline VALUE inputs ([98fa7db](98fa7db)), closes [#339](#339)
* add versioned documentation with Docusaurus ([03c2d3e](03c2d3e))
* adopt obsidian 1.11 settings APIs ([#1041](#1041)) ([15c4b34](15c4b34))
* default multi placeholder to name ([fcd058f](fcd058f))
* enhance template folder chooser ([f1e2a9f](f1e2a9f)), closes [#1011](#1011) [#1012](#1012)
* improve prompt labeling for VALUE/MACRO and multi choices ([78fd184](78fd184))
* persist input prompt drafts on cancel/escape ([#1044](#1044)) ([62a67f4](62a67f4))
* store AI provider keys in SecretStorage ([4559013](4559013))
* support short-form date aliases ([e04a3f6](e04a3f6))
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 28, 2026

🎉 This PR is included in version 2.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] [CSS] Multi Choice: Specific Class for ← Back suggestion item

1 participant

@chhoumann