-
-
Notifications
You must be signed in to change notification settings - Fork 175
feat(capture): fully support capture into canvas cards #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,721
−104
Merged
Changes from 7 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d852c29
feat(capture): add targeted canvas node capture
chhoumann 70ec2e6
chore(capture): apply review polish
chhoumann 908011d
fix(capture): abort .canvas capture without node id
chhoumann 66965a0
fix(capture): prevent concurrent canvas overwrite
chhoumann 74fec55
fix(capture): allow vault picker and clear stale canvas node ids
chhoumann 01d80d6
codex: address PR review feedback (#1124)
chhoumann 2eee632
codex: fix PR #1124 CI regressions
chhoumann de8e841
codex: avoid duplicate capture path formatting (#1124)
chhoumann e5a287e
codex: fix capture success notice placement (#1124)
chhoumann 49c2eae
codex: guard canvas file-card cursor fallback (#1124)
chhoumann 9f69be8
codex: restrict picker to capturable canvas nodes (#1124)
chhoumann 94e9a28
codex: remove redundant canvas destination source-path reset (#1124)
chhoumann cef9a59
codex: fix picker button disable typing (#1124)
chhoumann a63cce7
codex: address PR review feedback (#1124)
chhoumann e5bb166
codex: address PR review feedback (#1124)
chhoumann 3e8d167
codex: fix canvas capture correctness regressions (#1124)
chhoumann 1aea168
codex: harden stale canvas node config fallback (#1124)
chhoumann 577dea5
codex: add canvas file-card regressions and remove dead helpers (#1124)
chhoumann 4bb7627
fix(capture): abort invalid insert-after and align canvas link behavior
chhoumann 7885014
test(capture): assert choice abort notices are always visible
chhoumann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.