Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR fixes the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying quickadd with
|
| Latest commit: |
939cd46
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6b36395e.quickadd.pages.dev |
| Branch Preview URL: | https://1174-valueoption1option2-tex.quickadd.pages.dev |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
chhoumann
deleted the
1174-valueoption1option2|textdisplay1display2-capture-format-not-workversion-2120-obsidian-version-1127
branch
chhoumann
added a commit
that referenced
this pull request
May 5, 2026
Add regression coverage for labeled VALUE dropdown tokens
({{VALUE:option-a,option-b|label:Pick one}}) in the One-page
input modal. The bug reported in issue #1180 reproduced at
v2.12.0 — capture wrote an empty value instead of the selected
option. The runtime fix landed in PR #1175 (`resolveDropdownInitialValue`
+ missing `setValue(req.id, selectedValue)` in OnePageInputModal),
but only the unlabeled id case was covered by tests.
Closes #1180
chhoumann
added a commit
that referenced
this pull request
May 5, 2026
Add regression coverage for labeled VALUE dropdown tokens
({{VALUE:option-a,option-b|label:Pick one}}) in the One-page
input modal. The bug reported in issue #1180 reproduced at
v2.12.0 — capture wrote an empty value instead of the selected
option. The runtime fix landed in PR #1175 (`resolveDropdownInitialValue`
+ missing `setValue(req.id, selectedValue)` in OnePageInputModal),
but only the unlabeled id case was covered by tests.
Closes #1180
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mapped
VALUE|textCapture defaults when one-page preflight is enabled.The bug was that the one-page dropdown visually selected the first mapped option, but if the user submitted without touching the dropdown, the modal stored an empty string instead of the raw option value. Capture then treated that empty string as an intentional resolved value and emitted empty output like
background-color:.This change keeps formatter/runtime empty-string semantics intact and fixes the mismatch in the preflight dropdown path by seeding the submitted result with the same raw value the UI shows as selected. It also adds focused regression coverage and a live e2e covering the untouched-dropdown Capture flow.
Follow-up from review:
quickadd:runbehavior, using a narrowly scoped test-only diagnostic flag for CLI-verifiable one-page modal submissionValidation:
bun run buildFixes #1174
Summary by CodeRabbit
Bug Fixes
Tests