Skip to content

fix(proxy): close proxy when server closes#508

Merged
chimurai merged 1 commit into
masterfrom
proxy-close
Mar 28, 2021
Merged

fix(proxy): close proxy when server closes#508
chimurai merged 1 commit into
masterfrom
proxy-close

Conversation

@chimurai

@chimurai chimurai commented Mar 28, 2021

Copy link
Copy Markdown
Owner

fixes #189
fixes #287

Example Graceful Shutdown (source: https://expressjs.com):

process.on('SIGTERM', () => {
  debug('SIGTERM signal received: closing HTTP server')
  server.close(() => {
    debug('HTTP server closed')
  })
})

More on graceful server shutdown: https://expressjs.com/en/advanced/healthcheck-graceful-shutdown.html

@coveralls

coveralls commented Mar 28, 2021

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.7%) to 87.46% when pulling 32687ee on proxy-close into 7c3fd07 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No Graceful Shutdown? how can I shutdown proxy server?

2 participants