Add Swift 6 compatibility for async function code generation#362
Conversation
|
Hi @chinedufn, |
|
Hi @chinedufn, |
chinedufn
left a comment
There was a problem hiding this comment.
Looks good thanks. Just one minor piece of feedback about making it clear that if Swift 5 ever becomes too difficult to maintain we can remove it from the test matrix.
| timeout-minutes: 30 | ||
| strategy: | ||
| matrix: | ||
| swift_version: ['5.0', '6.0'] |
There was a problem hiding this comment.
FYI, our minimum support Swift version is 6.0, so if 5.0 ever causes problems we can remove it
Lines 170 to 173 in 82b0885
Let's leave leave a comment here in this test.yml. Something like:
# NOTE: As explained in `README.md`, the minimum supported Swift version is currently `6.0`.
# If supporting `5.0` ever becomes difficult we can consider removing it from the test matrix.| "# | ||
| } | ||
|
|
||
| /// A wrapper type that makes any value Sendable for use in Task closures. |
There was a problem hiding this comment.
Thanks for the clear documentation about safety.
|
Published as |
Add Swift 6 strict concurrency compatibility for generated async function code
Add
@MainActorto test classes using XCTContext.runActivityAdd CI matrix to test with both Swift 5.0 and Swift 6.0