Conversation
- Remove strap_prod_debug_unlock_pk_hash - Add Debug intent strap - Remove datavault and lockable scratch registers as we might not be able to add these in time for 2.0
…o ckuchta-ss-mci-reg-cleanup
- Add all MCI interrupts/error to MCI register bank - Add reset scan_mode control - Add MBOX AXI User parameters to match caliptra implementation - Add MBOX AXI USER filtering
- Add debug AXI access to MCI
…o ckuchta-ss-mci-reg-cleanup
…liance/caliptra-ss into ckuchta-ss-mci-trace-buffer
…eedback. Clean up other parts of the MCU Trace Buffer section.
…o ckuchta-ss-mci-trace-buffer
- Rearrange DMI addresses to add MCU_TRACE_BUFFER registers - Connect DMI write to MCU Trace Buffer - Fix size of trace_buffer_depth CSR - Connect MCU Trace Buffer DMI interface to main DMI interface
Contributor
There was a problem hiding this comment.
Copilot reviewed 26 out of 26 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
docs/CaliptraSSHardwareSpecification.md:1134
- Formatting issue: unexpected 'D' in the register access field. It likely should read as 'RO' without the extra character.
| HW_ERROR_NON_FATAL | 0x65 D RO | Yes | | |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
calebofearth
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.