[fuse_ctrl,dv] Assorted cleanups to how FC tests look at magic registers#750
Merged
[fuse_ctrl,dv] Assorted cleanups to how FC tests look at magic registers#750
Conversation
Contributor
Author
|
Hmm, that's annoying: the promote pipeline just pushed a magic commit as the wrong user This causes easyCLA to fail. Grr. I'll try to figure out where the MS machine is getting the bogus email address from, but I'm convinced this is good to go otherwise. EDIT: Ahah! I just had to teach GitHub that my Microsoft account was associated with this user (and force-push to the head of the branch to get EasyCLA to re-do its check) |
rswarbrick
force-pushed
the
lowrisc_fuse_ctrl_partition_regs
branch
from
4178619 to
b10353a
Compare
andreaskurth
previously approved these changes
Sep 30, 2025
Contributor
andreaskurth
left a comment
andreaskurth
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing these tests, @rswarbrick
This avoids fuse_ctrl_mmap.h defining something that actually gets instantiated (and defines a symbol). Without fixing that, if more than one compilation unit includes the header then link will fail because more than one object file defines "partitions" and various fuse index arrays.
No functional change (but hopefully it makes things a bit clearer: I found these ranges a bit hard to reason about).
The value in caliptra_ss_fuse_ctrl_manuf_prod_prov hadn't yet been updated for the change in 275521b. This change should make it so that test and also caliptra_ss_fuse_ctrl_init_fail get a magic number from a single (documented) place. Apply the same change to caliptra_ss_fuse_ctrl_test_unlocked0_prov.
This is a bit fiddly to do properly, because you end up needing to map from a partition with a read lock to that partition's read lock address (which depends on soc_mmap.h). My solution is to have a template generate that map (which will contain actual addresses that get pulled from soc_mmap.h at compile time).
rswarbrick
force-pushed
the
lowrisc_fuse_ctrl_partition_regs
branch
from
b10353a to
cf0070d
Compare
…' with updated timestamp and hash after successful run
andreaskurth
approved these changes
Sep 30, 2025
Contributor
andreaskurth
left a comment
andreaskurth
left a comment
There was a problem hiding this comment.
Re-approving after promote pipeline has passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made this changes while trying to tidy up #727. I'm not convinced that some of the changes in that PR are correct, but these changes should be safe to apply separately.