[RTL] Make lc_ctrl RAW unlock token a caliptra_ss_top input signal#782
Merged
[RTL] Make lc_ctrl RAW unlock token a caliptra_ss_top input signal#782
Conversation
ekarabu
reviewed
Oct 2, 2025
Collaborator
|
There is a compile.yml error |
Contributor
Author
Thx; let me resolve that. Actually, the way I understand the check it's OK if a MSFT contributor does it -- are you happy if I add myself to the list (Andi and Pascal are also on the list)? --> Done. |
andreaskurth
force-pushed
the
lowrisc_raw_unlock_token
branch
from
c740e04 to
35dbfa9
Compare
moidx
previously approved these changes
Oct 2, 2025
martin-velay
force-pushed
the
lowrisc_raw_unlock_token
branch
from
35dbfa9 to
31db851
Compare
This is required so that CI doesn't fail for the next two commits.
martin-velay
force-pushed
the
lowrisc_raw_unlock_token
branch
2 times, most recently
from
de87a4e to
430682b
Compare
Before this change, lc_ctrl's RAW unlock token was defined in `lc_ctrl_state_pkg`, which lives in the `caliptra-rtl` submodule repository. This is problematic as integrators need to be able to change the RAW unlock token but should not change the `caliptra-rtl` repository. This change makes the (hashed) RAW unlock token an input signal of `caliptra_ss_top` and propagates the signal down to `lc_ctrl`. Integrators can thus simply define the value of the RAW unlock token by assigning a signal (which can be driven by a constant) to `caliptra_ss_top`'s `cptra_ss_raw_unlock_token_hashed_i` input.
martin-velay
force-pushed
the
lowrisc_raw_unlock_token
branch
from
430682b to
d0db09f
Compare
…pdated timestamp and hash after successful run
…pdated timestamp and hash after successful run
ekarabu
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, lc_ctrl's RAW unlock token was defined in
lc_ctrl_state_pkg, which lives in thecaliptra-rtlsubmodulerepository. This is problematic as integrators need to be able to
change the RAW unlock token but should not change the
caliptra-rtlrepository.
This change makes the (hashed) RAW unlock token an input signal of
caliptra_ss_topand propagates the signal down tolc_ctrl.Integrators can thus simply define the value of the RAW unlock token by
assigning a signal (which can be driven by a constant) to
caliptra_ss_top'scptra_ss_raw_unlock_token_hashed_iinput.The second commit removes the unused
otp_ctrl_token_constmodule.This doesn't yet change the RAW unlock token value and add guidance for integrators on how to do that. That will be done in a follow-up PR or commit, depending on the timeline.
This contributes to the resolution of Issue #687.