[v1p0,RTL] Make lc_ctrl RAW unlock token a caliptra_ss_top input signal#785
Merged
ekarabu merged 7 commits intopatch_ss_v1p0from Oct 8, 2025
Merged
[v1p0,RTL] Make lc_ctrl RAW unlock token a caliptra_ss_top input signal#785ekarabu merged 7 commits intopatch_ss_v1p0from
ekarabu merged 7 commits intopatch_ss_v1p0from
Conversation
This is required so that CI doesn't fail for the next two commits.
Collaborator
|
Fails the promote-pipeline: FILE LIST CHECK CALIPTRA SUBSYSTEM run_clp_github_val_flow : "False" |
andreaskurth
force-pushed
the
lowrisc_ss_v1p0_raw_unlock_token
branch
from
4b1a90a to
91626cc
Compare
Before this change, lc_ctrl's RAW unlock token was defined in `lc_ctrl_state_pkg`, which lives in the `caliptra-rtl` submodule repository. This is problematic as integrators need to be able to change the RAW unlock token but should not change the `caliptra-rtl` repository. This change makes the (hashed) RAW unlock token an input signal of `caliptra_ss_top` and propagates the signal down to `lc_ctrl`. Integrators can thus simply define the value of the RAW unlock token by assigning a signal (which can be driven by a constant) to `caliptra_ss_top`'s `cptra_ss_raw_unlock_token_hashed_i` input.
This hashed and the unhashed RAW unlock token were generated with `tools/scripts/lc_ctrl_script/gen_lc_ctrl_token.py`.
andreaskurth
force-pushed
the
lowrisc_ss_v1p0_raw_unlock_token
branch
from
91626cc to
7bc5e0e
Compare
…' with updated timestamp and hash after successful run
Contributor
Author
|
Fixed; the promote pipeline has passed. I've also cherry-picked commits from #792 to validate the token change flow and update the HW spec and integration guidelines. |
ekarabu
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, lc_ctrl's RAW unlock token was defined in
lc_ctrl_state_pkg, which lives in thecaliptra-rtlsubmodulerepository. This is problematic as integrators need to be able to
change the RAW unlock token but should not change the
caliptra-rtlrepository.
This change makes the (hashed) RAW unlock token an input signal of
caliptra_ss_topand propagates the signal down tolc_ctrl.Integrators can thus simply define the value of the RAW unlock token by
assigning a signal (which can be driven by a constant) to
caliptra_ss_top'scptra_ss_raw_unlock_token_hashed_iinput.This contributes to resolving Issue #784.