Conversation
Merged
a4926e4 to
8e4e585
Compare
Closed
29adb76 to
6c52683
Compare
Collaborator
|
Did we re-run the script after updating the template files? |
41851b5 to
821e7c6
Compare
Contributor
Author
|
Well, this has had quite a noisy history (sorry). This now builds on top of #806 and the last 6 commits are unique to this PR. I have started a run of the promote pipeline: job 20251009.11. |
This accidentally got broken in 5cc9dbe.
Also add an explicit documentation comment in the header file that explains how "num_fuses" relates to what is specified in the hjson file: it took me a while to figure it all out.
No functional change, but the debug messages should be a lot clearer.
This is also declared in lc_ctrl.h (where it belongs). Don't duplicate the declaration here.
This is in lc_ctrl.h, so there's no need to have a copy on smoke_test_fuse_prov_with_axi_id.
Contributor
Author
|
Promote pipeline running as 20251009.15 |
…p and hash after successful run
ekarabu
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #806 and the last 6 commits are unique to this PR.