move ROM size parameters to ss_top level declaration#816
Open
move ROM size parameters to ss_top level declaration#816
Conversation
…ith updated timestamp and hash after successful run
…ith updated timestamp and hash after successful run
| @@ -1002,8 +1002,8 @@ module caliptra_ss_top_tb | |||
| ); | |||
|
|
|||
| axi_mem_if #( | |||
Collaborator
There was a problem hiding this comment.
Should we also set the appropriate AXI address width on line 268
…ith updated timestamp and hash after successful run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the ROM size parameters to the top level of caliptra_ss_top so integrators don't have to edit ss_includes.