Fix: Restore .getValue() for characteristic updates (fixes Nest Prote… #721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #693 (duplicate of closed/stale #705 and solves the same problem as #713)
Problem
In v4.6.10, the Nest Protect occupancy sensor stopped updating correctly in HomeKit, causing automations to fail. The issue was introduced in commit 9795793 where
.getValue()was replaced with.valuein the characteristic update logic.Root Cause
.getValue()triggers the characteristic's 'get' event handler, which calls the bound function (likegetOccupancyDetected()) and updates the characteristic value properly.valuejust accesses the property directly without triggering the 'get' event handler, so the characteristic value is never updated with the current device stateFix
.valueback to.getValue()in theupdateDatamethod inlib/nest-device-accessory.jsindex.jserror handling sectionTesting
Fixes #675 (the original HB2 compatibility issue that introduced this regression)