Skip to content

Onboarding: Replace react-confetti with @neoconfetti/react #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

Onboarding: Replace react-confetti with @neoconfetti/react #372

merged 1 commit into from
May 19, 2025

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld added patch Auto: Increment the patch version when merged dependencies Pull requests that update a dependency file labels May 16, 2025
@ghengeveld ghengeveld requested a review from ndelangen May 16, 2025 15:19
@ghengeveld ghengeveld added the skip-release Auto: Preserve the current version when merged label May 16, 2025
@codecov Codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 6.03%. Comparing base (cdec3a9) to head (791c413).

Files with missing lines Patch % Lines
src/screens/GuidedTour/Confetti.tsx 0.00% 25 Missing and 1 partial ⚠️
src/screens/GuidedTour/GuidedTour.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##            next    #372      +/-   ##
========================================
+ Coverage   6.00%   6.03%   +0.03%     
========================================
  Files        169     169              
  Lines      14282   14198      -84     
  Branches     302     302              
========================================
  Hits         857     857              
+ Misses     13343   13259      -84     
  Partials      82      82

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghengeveld ghengeveld merged commit 85c3db0 into next May 19, 2025
8 of 12 checks passed
@ghengeveld ghengeveld deleted the replace-react-confetti branch May 19, 2025 09:35
@ghengeveld ghengeveld mentioned this pull request May 19, 2025
Closed
This was referenced May 21, 2025
Merged
Merged
Merged
Merged
@ghengeveld
Copy link
Member Author

🚀 PR was released in v4.0.0 🚀

@ghengeveld ghengeveld added released Verdict: This issue/pull request has been released and removed prerelease labels May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

@valentinpalkovic valentinpalkovic Awaiting requested review from valentinpalkovic

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghengeveld @yannbf