Skip to content

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Jun 15, 2023

Screenshot 2023-06-14 at 10 50 52
📦 Published PR as canary version: 0.0.4-canary.7.37dda05.0

✨ Test out this PR locally via:

npm install @chromaui/[email protected]
# or 
yarn add @chromaui/[email protected]

@ghengeveld ghengeveld changed the title Implement test screens Implement test screen UI Jun 15, 2023
Base automatically changed from storybook-addon-designs to storybook-setup June 20, 2023 10:07
@ghengeveld ghengeveld changed the base branch from storybook-setup to main June 20, 2023 12:50
@weeksling
Copy link
Contributor

weeksling commented Jun 27, 2023

Could we merge the work from this branch up until this commit that didn't have the component extension issues or rely on the completed api? I believe that is this commit:
@ghengeveld Loading states
696022d

I've been keeping my branch up to date with this one because of file/directory renaming conflicts and graphql changes. It would be easier to collaborate from a stable main branch.
It seems like merging those changes up to the loading screens would close out your in progress ticket: https://linear.app/chromaui/issue/AP-3316/show-most-recent-test-result-for-selected-story-in-addon-panel
And it would make the latest changes you've been working on easier to review and report in linear since they seem to specifcally touch the chromatic/node api and the build query which have separate tickets.

@weeksling
Copy link
Contributor

@ghengeveld when I run this branch locally, I now get the following error in pnpm run build:watch.
Screen Shot 2023-07-07 at 4 47 31 PM

@ghengeveld
Copy link
Member Author

@ghengeveld when I run this branch locally, I now get the following error in pnpm run build:watch.

Should be resolved now.

@ghengeveld ghengeveld merged commit 37dda05 into main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants