Skip to content

Merging temporary branch to master#14

Merged
adibas03 merged 38 commits into
masterfrom
push-resolver
Jan 22, 2018
Merged

Merging temporary branch to master#14
adibas03 merged 38 commits into
masterfrom
push-resolver

Conversation

@kosecki123
Copy link
Copy Markdown
Contributor

New features:

  • deployer contract
  • changes in vocabulary

Copy link
Copy Markdown
Member

@adibas03 adibas03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet ready.
Work still in Progress

@adibas03 adibas03 changed the title Merging temporary branch to master WIP : Merging temporary branch to master Jan 19, 2018
@adibas03
Copy link
Copy Markdown
Member

closing this, for now,
Till it is ready

@adibas03 adibas03 closed this Jan 19, 2018
@adibas03 adibas03 mentioned this pull request Jan 22, 2018
@adibas03 adibas03 changed the title WIP : Merging temporary branch to master Merging temporary branch to master Jan 22, 2018
@adibas03 adibas03 reopened this Jan 22, 2018
@kosecki123
Copy link
Copy Markdown
Contributor Author

1 thing missing, commits in the PR closes bug with getLoanValue it would be great if we have a specific unit test for that bug, currently our exchangeRate in tests is set to 1, so actually, we are not checking here for correctness.

@adibas03
Copy link
Copy Markdown
Member

Sounds good.
But you can view a contract on Ropsten with a different exchange rate here:
https://ropsten.etherscan.io/address/0xa0874c2d1a52f04b4985c795f13a3d033b48f3e5

@adibas03 adibas03 merged commit f8edc5a into master Jan 22, 2018
@adibas03 adibas03 deleted the push-resolver branch January 22, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants