Feature/round_up method on DurationRound trait#1651
Merged
djc merged 12 commits intochronotope:mainfrom Jan 20, 2025
MagnumTrader:feature/round_up
Merged
Feature/round_up method on DurationRound trait#1651djc merged 12 commits intochronotope:mainfrom MagnumTrader:feature/round_up
djc merged 12 commits intochronotope:mainfrom
MagnumTrader:feature/round_up
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1651 +/- ##
==========================================
+ Coverage 90.87% 91.01% +0.13%
==========================================
Files 37 37
Lines 17143 17342 +199
==========================================
+ Hits 15579 15784 +205
+ Misses 1564 1558 -6 ☔ View full report in Codecov by Sentry. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Solves #1650.
Implementation of duration_round_up method by inverting the duration_trunc method.