Skip to content

Feature/round_up method on DurationRound trait#1651

Merged
djc merged 12 commits intochronotope:mainfrom
MagnumTrader:feature/round_up
Jan 20, 2025
Merged

Feature/round_up method on DurationRound trait#1651
djc merged 12 commits intochronotope:mainfrom
MagnumTrader:feature/round_up

Conversation

@MagnumTrader
Copy link
Copy Markdown
Contributor

This PR Solves #1650.

Implementation of duration_round_up method by inverting the duration_trunc method.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.01%. Comparing base (82bacb8) to head (c0f9d2f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1651      +/-   ##
==========================================
+ Coverage   90.87%   91.01%   +0.13%     
==========================================
  Files          37       37              
  Lines       17143    17342     +199     
==========================================
+ Hits        15579    15784     +205     
+ Misses       1564     1558       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo a small nit.

Comment thread src/round.rs
@djc djc merged commit 5f2f5a8 into chronotope:main Jan 20, 2025
@djc
Copy link
Copy Markdown
Member

djc commented Jan 20, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants