Skip to content

Scaffolding improvements #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fdcastel wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Scaffolding improvements #120

fdcastel wants to merge 20 commits into from

Conversation

@fdcastel
Copy link
Contributor

@fdcastel fdcastel commented Jul 11, 2023 •
edited
Loading

Fix #1104

This PR adds to scaffolding code:

  • Ability to distinguish NUMERIC from DECIMAL datatypes.
  • Precision and Scale for NUMERIC/DECIMAL column types.
  • Collation for CHAR/VARCHAR column types.
  • Expression for COMPUTED BY columns.

Other changes (may affect other tests?):

  • Adds COLLATE UNICODE_FSS to CS_FIELD column in FbTestsSetup.CreateTables().

Minor changes:

  • Refactor GetColumnsQuery

ToDo / Checklist:

  • Manual tests with dotnet ef dbcontext scaffold (in progress)
  • BLOB Segment size
  • DEFAULT values
  • Comments
  • CHARSET
  • GENERATED ALWAYS/BY DEFAULT AS IDENTITY

Firebird 4+:

  • DECFLOAT
  • INT128
  • TIME WITH TIME ZONE
  • TIMESTAMP WITH TIME ZONE

Aborted

  • CHECK Constraints
  • Global Temporary Tables (GTT)

Remarks

The changes are being made only in scaffolding code.

Database (DDL script) generation and migrations should be done in a separate (future) PR.`

@fdcastel
Copy link
Contributor Author

fdcastel commented Jul 11, 2023

@cincuranet How do you build "debug" nuget packages on your machine?

It seems the current build.ps1 doesn't contains anything related to this.

In other words: how did you build 9.2.0-alpha1?

I wish to tag and use my locally-built package (e.g. 9.2.1-dev) in one test application to check the result of code generated by dotnet ef dbcontext scaffold command.

@cincuranet
Copy link
Owner

cincuranet commented Jul 12, 2023

Change the versions in Directory.Build.props.

@fdcastel
Copy link
Contributor Author

fdcastel commented Jul 12, 2023

Change the versions in Directory.Build.props.

Update: passing /p:VERSIONSUFFIX=alpha2 to dotnet msbuild has the same effect, without the need to change any source file -- useful for passing parameters to build scripts.

@fdcastel
Copy link
Contributor Author

fdcastel commented Jul 12, 2023 •
edited
Loading

@cincuranet I believe this could be merged, now.

When possible, please review.

@cincuranet
Copy link
Owner

cincuranet commented Oct 1, 2023 •
edited
Loading

@fdcastel Can you please resolve the conflicts. Thanks.

@fdcastel
Copy link
Contributor Author

fdcastel commented Oct 1, 2023

@fdcastel Can you please resolve the conflicts. Thanks.

Sure! Done!

@fdcastel
Copy link
Contributor Author

fdcastel commented Oct 1, 2023

Sorry. Hold on. Some EF tests failing.

@fdcastel
Copy link
Contributor Author

fdcastel commented Oct 1, 2023

Fixed! (Bad rebase)

@cincuranet cincuranet self-requested a review August 26, 2024 18:23
cincuranet
cincuranet requested changes Aug 28, 2024
View reviewed changes
fdcastel added 14 commits October 25, 2024 02:36
@fdcastel
Scaffolding improvements.
c9aba60 
- Ability to distinguish NUMERIC from DECIMAL datatypes.
- Precision and Scale for NUMERIC/DECIMAL column types.
- Collation for CHAR/VARCHAR column types.
- Expression for COMPUTED BY columns.
- Refactor GetColumnsQuery.
@fdcastel
Scaffolding: retrieves BlobSegmentSize, CharacterSet, DomainName, Ide…
ab114d4 
…ntityType, IdentityStart and IdentityIncrement from database.
@fdcastel
Adds tests for GENERATED BY identities.
fc4264b
@fdcastel
Scaffolding: adds new data types (Firebird 4+).
6b32efe
@fdcastel
Scaffolding: Adds Trim() to ColumnDomain.
b3d6035
@fdcastel
Fix rebase error.
ba63a06
@fdcastel
GetColumns: Fix integer subtypes. Minor formatting fixes.
753f1c4
@fdcastel
Fix DECFLOAT (Firebird 4+).
53cd0a1
@fdcastel
Uses ServerVersionAtLeast.
ed7c0e3
@fdcastel
Fix authors.
6f97f6b
@fdcastel
Remove unnecessary private modifiers.
4d4b841
@fdcastel
Fix parameter name.
3cec5a1
@fdcastel
Trim() in SQL.
b25c4da
@fdcastel
Removes modelFactory from SetUp.
9fc4703
@fdcastel
Copy link
Contributor Author

fdcastel commented Oct 25, 2024 •
edited
Loading

Rebased with the latest master and addressed nearly all requested changes.

@fdcastel
Copy link
Contributor Author

fdcastel commented Oct 25, 2024

@cincuranet All done!

Please review and let's close this PR, as it has been pending for quite some time 🎂...

@fdcastel
Copy link
Contributor Author

fdcastel commented Nov 9, 2024

@cincuranet any change to merge these soon?

@cincuranet cincuranet force-pushed the master branch 2 times, most recently from 2dc214c to e439935 Compare December 10, 2024 10:41
@cincuranet cincuranet force-pushed the master branch 2 times, most recently from d944a22 to c6ff107 Compare November 22, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cincuranet cincuranet cincuranet requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Decimal truncation on Database First Approach

2 participants

@fdcastel @cincuranet