Skip to content

Add contact form back#385

Merged
witha-k merged 1 commit into
mainfrom
ky/contact-form
Apr 9, 2025
Merged

Add contact form back#385
witha-k merged 1 commit into
mainfrom
ky/contact-form

Conversation

@witha-k
Copy link
Copy Markdown
Contributor

@witha-k witha-k commented Apr 8, 2025

Ticket

Changes

Context for reviewers

Setup

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

  • Met the acceptance criteria, or will meet them in a subsequent PR
  • Created/modified automated tests
  • Update documentation in READMEs and/or onboarding guide

Ensured code standards are met (Original Developer)

  • Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

  • Tag @dotgov-designers in this PR's Reviewers for design review. If code is not user-facing, delete design reviewer checklist
  • Verify new pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
  • Checked keyboard navigability
  • Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

  • Pulled this branch locally and tested it
  • Verified code meets all checks above. Address any checks that are not satisfied
  • Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
  • Checked that all code is adequately covered by tests

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

  • New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
  • Checked keyboard navigability
  • Meets all designs and user flows provided by design/product
  • Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

As a designer reviewer, I have

Verified that the changes match the design intention

  • Checked that the design translated visually
  • Checked behavior. Comment any found issues or broken flows.
  • Checked different states (empty, one, some, error)
  • Checked for landmarks, page heading structure, and links

Validated user-facing changes as a designer

  • Checked keyboard navigability
  • Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
  • Tested with multiple browsers (check off which ones were used)
    • Chrome
    • Microsoft Edge
    • FireFox
    • Safari

Screenshots

@witha-k witha-k requested review from a team and h-m-f-t April 8, 2025 01:12
@witha-k witha-k moved this to ✅ Done in .gov Product Board Apr 8, 2025
@witha-k witha-k moved this from ✅ Done to 👀 In review in .gov Product Board Apr 8, 2025
Copy link
Copy Markdown
Member

@h-m-f-t h-m-f-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU!

Non-blocking: Can you remove the extra spaces from the href in the Microsoft Form markup?

image

@witha-k witha-k merged commit 6c2f9c8 into main Apr 9, 2025
4 checks passed
@witha-k witha-k deleted the ky/contact-form branch April 9, 2025 15:24
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in .gov Product Board Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants