Skip to content

Add 2 analyst test accounts to fixtures#4764

Merged
witha-k merged 1 commit into
mainfrom
yellowstone/analyst-test-accounts
Mar 6, 2026
Merged

Add 2 analyst test accounts to fixtures#4764
witha-k merged 1 commit into
mainfrom
yellowstone/analyst-test-accounts

Conversation

@witha-k
Copy link
Copy Markdown
Contributor

@witha-k witha-k commented Mar 5, 2026

Ticket

Partially address #4740

Changes

I created "fake" accounts to use for user research testing across all the sandboxes. We want two of them to have "analyst" permissions to test with analysts specifically. In this PR, I've added the two fake analyst accounts to fixtures.

Setup

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

  • Met the acceptance criteria, or will meet them in a subsequent PR
  • Created/modified automated tests
  • Update documentation in READMEs and/or onboarding guide

Ensured code standards are met (Original Developer)

  • If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
  • Interactions with external systems are wrapped in try/except
  • Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

  • Follow the process for requesting a design review. If code is not user-facing, delete design reviewer checklist
  • Verify new pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
  • Checked keyboard navigability
  • Reviewed accessibility checklist using screen reader (such as NVDA with Chrome or Voiceover with Safari), ANDI, or WAVE:
    • Tested general usability
    • Page header structure
    • Landmarks
    • Links and buttons
  • Checked for errors or warnings with an a11y browser tool (such as ANDI or WAVE)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

  • Pulled this branch locally and tested it
  • Verified code meets all checks above. Address any checks that are not satisfied
  • Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
  • Checked that all code is adequately covered by tests
  • Verify migrations are valid and do not conflict with existing migrations

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

  • New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
  • Meets all designs and user flows provided by design/product
  • Checked keyboard navigability
  • Reviewed accessibility checklist using screen reader (such as NVDA with Chrome or Voiceover with Safari), ANDI, or WAVE:
    • Tested general usability
    • Page header structure
    • Landmarks
    • Links and buttons
  • Checked for errors or warnings with an a11y browser tool (such as ANDI or WAVE)
  • (Rarely needed) Tested as both an analyst and applicant user

As a designer reviewer, I have

Verified that the changes match the design intention

  • Checked that the design translated visually
  • Checked behavior. Comment any found issues or broken flows.
  • Checked different states (empty, one, some, error)
  • Checked for landmarks, page heading structure, and links

Validated user-facing changes as a designer

  • Checked keyboard navigability
  • Reviewed accessibility checklist using screen reader (such as NVDA with Chrome or Voiceover with Safari), ANDI, or WAVE:
    • Tested general usability
    • Page header structure
    • Landmarks
    • Links and buttons
  • Checked for errors or warnings with an a11y browser tool (such as ANDI or WAVE)
  • Tested with multiple browsers (check off which ones were used)
    • Chrome
    • Microsoft Edge
    • FireFox
    • Safari
  • (Rarely needed) Tested as both an analyst and applicant user

References

Screenshots

@waiwanwong waiwanwong self-requested a review March 6, 2026 20:47
@SamiyahKey SamiyahKey requested review from SamiyahKey and removed request for SamiyahKey March 6, 2026 20:55
Copy link
Copy Markdown

@waiwanwong waiwanwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@witha-k witha-k merged commit 989242a into main Mar 6, 2026
10 checks passed
@witha-k witha-k deleted the yellowstone/analyst-test-accounts branch March 6, 2026 21:17
@witha-k witha-k mentioned this pull request Mar 10, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants