Skip to content

Add descriptions for new output fields#187

Merged
jsf9k merged 5 commits into
developfrom
improvement/cleanup
Mar 20, 2019
Merged

Add descriptions for new output fields#187
jsf9k merged 5 commits into
developfrom
improvement/cleanup

Conversation

@jsf9k

@jsf9k jsf9k commented Mar 20, 2019

Copy link
Copy Markdown
Member

cc @echudow

I took a stab at adding descriptions for the new output fields in the README. Please review and let me know (or commit) if anything is not accurate.

@jsf9k jsf9k self-assigned this Mar 20, 2019
@jsf9k jsf9k requested review from a team and IanLee1521 March 20, 2019 11:39
@jsf9k

jsf9k commented Mar 20, 2019

Copy link
Copy Markdown
Member Author

This pull request fixes 1 alert when merging e656fd2 into cd5d0c9 - view on LGTM.com

fixed alerts:

  • 1 for Nested loops with same variable

Comment posted by LGTM.com

@dav3r dav3r left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the small typo that I noted.

Comment thread README.md Outdated
@jsf9k

jsf9k commented Mar 20, 2019

Copy link
Copy Markdown
Member Author

This pull request fixes 1 alert when merging 7054602 into cd5d0c9 - view on LGTM.com

fixed alerts:

  • 1 for Nested loops with same variable

Comment posted by LGTM.com

@jsf9k

jsf9k commented Mar 20, 2019

Copy link
Copy Markdown
Member Author

This pull request fixes 1 alert when merging d7b6165 into cd5d0c9 - view on LGTM.com

fixed alerts:

  • 1 for Nested loops with same variable

Comment posted by LGTM.com

@jsf9k jsf9k merged commit 90b3f2d into develop Mar 20, 2019
@jsf9k jsf9k deleted the improvement/cleanup branch March 20, 2019 15:17
cisagovbot pushed a commit that referenced this pull request Jan 31, 2025
Use an Action to install Packer in our GitHub Actions workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants