Merged
Conversation
The mirrors-isort respository has been deprecated per this Pull Request: pre-commit/mirrors-isort#13 Since isort includes pre-commit configuration in current versions we will switch to using it directly.
This comment references the mirrors-isort repository that we are no longer using.
We have seen a number of issues related to this hook ever since it was re-enabled. It will need to remain disabled until at least the 0.13 Terraform release, and can only be re-enabled if all issues we have seen have been resolved in how `terraform validate` operates.
mcdonnnj
requested review from
a team,
dav3r,
felddy,
hillaryj and
jsf9k
as code owners
dav3r
approved these changes
May 13, 2020
Member
dav3r
left a comment
dav3r
left a comment
There was a problem hiding this comment.
Approved, though please see my request for an addition to a comment.
↪️
…bled. Review noticed that there lacked a determination for what we were doing about the problem with the terraform_validate hook. I described the problems but failed to mention what our path forward would be. This commit rectifies that oversight.
…om:cisagov/skeleton-generic into improvements/pre-commit_autoupdate_2020-05
Member
|
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
In an effort to keep things up to date I am trying to run a
pre-commit autoupdatemonthly to refresh hooks. This is the result of this effort.The pre-commit/mirrors-isort repository has been deprecated since
isortnow contains appropriate code to run as apre-commithook. The repository used in thepre-commitconfiguration have been updated appropriately.We have seen a number of issues from using the
terraform_validatehook. These have primarily been related to proxy providers and Terraform code using remote state. The issue with remote state can be read about at hashicorp/terraform#21408, and the issue with proxy providers has been wrapped into that issue as described in this reply: hashicorp/terraform#21706 (comment). There is an accepted PR (hashicorp/terraform#24887) for remote state that is included in the future Terraform 0.13 release. I am unsure if it will resolve issues with proxy providers as there is another PR (hashicorp/terraform#24896) waiting for feedback that attempts to deal with that specifically.💭 Motivation and Context
Updates are good, fixing problems is good, things are good 👍
🧪 Testing
All automated tests pass.
📷 Screenshots (if appropriate)
🚥 Types of Changes
✅ Checklist