Skip to content

Update CONTRIBUTING to call out presentational components #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update CONTRIBUTING to call out presentational components #352

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22c2538
Update CONTRIBUTING so call out presentational components
dkordik Nov 5, 2021
1865609
CONTRIBUTING.md - remove redundant component-writing guidelines
dkordik Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
# Contributing to RoverUI

## What to avoid in RoverUI

It's _not_ a repository for all shared components. Don't try to add components that deal specifically with business logic and concepts here. Don't try to add components that handle whole layout areas. This is a UI library only.

## Run locally

1. Read the [Code Guidelines](./CODE_GUIDELINES.md)
Expand Down