Open
Conversation
ChrispinP
added
WIP
JavaScript
ChrispinP
requested review from
ChristinaTremel,
KaroEngstrom,
dianamartin and
susannegov
susannegov
requested changes
Oct 8, 2025
Contributor
susannegov
left a comment
susannegov
left a comment
There was a problem hiding this comment.
Please change this to a view based API call instead of a object based API call in the Test Traffic Register app. Since there is only three views calling the newSortOrder() and object based api calls are insecure.
I have reset the API key with Christina's permission in the test version so it does not work now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the result of discovery work on #22983. In the issue you can see a demo of the sorting in action, and is currently live in Test Traffic Register for the Draft Builder. The API key is hashed for security and we will want to come up with a secure solution that can replicated. This code can be potentially be used for other apps that need record row sorting as well!
