Update should_sync_ecapris_statuses to false for projects without eCAPRIS IDs#1613
Merged
roseeichelmann merged 4 commits intoJul 2, 2025
Merged
Conversation
✅ Deploy Preview for atd-moped-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
roseeichelmann
requested review from
chiaberry,
frankhereford,
johnclary,
mateoclarke,
mddilley and
tillyw
mddilley
approved these changes
Jun 20, 2025
Collaborator
mddilley
left a comment
mddilley
left a comment
There was a problem hiding this comment.
Tested this with some SQL queries, and there are no projects without eCAPRIS ids that have syncing turned on. Also tested creating a new project, and I no longer see that awkward state with the disabled toggle that is switched on.
Thanks again for catching - and fixing! 🙏 🚢
johnclary
approved these changes
Jul 1, 2025
| @@ -0,0 +1 @@ | |||
| alter table "public"."moped_project" alter column "should_sync_ecapris_statuses" set default 'true'; | |||
Member
There was a problem hiding this comment.
If desired we could suppress triggers/activity logs using the old SET session_replication_role = replica; trick
Collaborator
There was a problem hiding this comment.
i say let's go for it! i often forget about this trick so this will help me keep it in mind. 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated issues
Closes cityofaustin/atd-data-tech#23041
Testing
URL to test:
Local
Steps to test:
moped_projectstable without anecapris_subproject_id. See that theshould_sync_ecapris_statuses = true. Copy that project id to look up latershould_sync_ecapris_statuses = falseshould_sync_ecapris_statuses = falseShip list
[ ] Product manager added to QA test script if applicable