23235 add lane conversion work type to various components#1619
Merged
tillyw merged 4 commits intoJul 2, 2025
Conversation
✅ Deploy Preview for atd-moped-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tillyw
commented
Jun 27, 2025
tillyw
requested review from
chiaberry,
frankhereford,
johnclary,
mateoclarke,
mddilley and
roseeichelmann
and removed request for
johnclary
mddilley
approved these changes
Jul 2, 2025
Collaborator
mddilley
left a comment
mddilley
left a comment
There was a problem hiding this comment.
Ran the migrations up and down, and I see the new work types in the component UI and the data dictionary too. Thanks for adding these! 🙏 🚀
roseeichelmann
approved these changes
Jul 2, 2025
Contributor
roseeichelmann
left a comment
roseeichelmann
left a comment
There was a problem hiding this comment.
ran the up and down migrations and this looks good! 🚀
frankhereford
approved these changes
Jul 2, 2025
Member
frankhereford
left a comment
frankhereford
left a comment
There was a problem hiding this comment.
SQL looks great and applied cleanly in both directions. Thanks Tilly!
The insert into sourced from the select is really elegant. ✨
tillyw
deleted the
23235_add_lane_conversion_work_type_to_various_components
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated issues
fixes cityofaustin/atd-data-tech#23235
Testing
URL to test:
local due to database changes
Steps to test:
Ship list
[ ] Product manager added to QA test script if applicable