Skip to content

Disable eCAPRIS Notes Filter#1620

Merged
roseeichelmann merged 5 commits into
mike/21794_show_ecapris_statusesfrom
rose/22702_disable_ecapris_filter
Jul 2, 2025
Merged

Disable eCAPRIS Notes Filter#1620
roseeichelmann merged 5 commits into
mike/21794_show_ecapris_statusesfrom
rose/22702_disable_ecapris_filter

Conversation

@roseeichelmann
Copy link
Copy Markdown
Contributor

@roseeichelmann roseeichelmann commented Jun 30, 2025

Associated issues

Closes cityofaustin/atd-data-tech#22702

Testing

URL to test:

Local

Steps to test:

  1. Use prod replica data so you can actually see projects that have eCAPRIS statuses
  2. Go to the Notes tab of a project that has an eCAPRIS id (For example: https://localhost:3000/moped/projects/3248?tab=notes). Use the toggle button to turn off eCAPRIS syncing
  3. See that the "Synced from eCAPRIS" filter button gets disabled and has a tooltip when you hover
  4. Turn the syncing toggle back on and see that you can now see and filter to eCAPRIS statuses
  5. Test removing the eCAPRIS id from the summary or funding page, then return to the Notes tab and see that the button is disabled again

Ship list

Copy link
Copy Markdown
Member

@johnclary johnclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the test steps and they checked out. Code looks great 🚢 🚢 🚢 🚢

Copy link
Copy Markdown
Collaborator

@mddilley mddilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks for taking care of this last piece of the puzzle. 🧩 🙏 🚢

}) => {
return (
<Tooltip title={isDisabled ? disabledMessage : ""}>
<span>
Copy link
Copy Markdown
Collaborator

@mddilley mddilley Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a TIL for me that tooltips won't show on disabled buttons since user interactions don't trigger on them. Could you add a comment or link to the docs here to help us avoid an accidental regression / deletion of that important span? 🙏

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I could definitely see future me deleting this span that is silently doing so much work here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh thanks for reminding me to comment about this! i meant to :))

Copy link
Copy Markdown
Member

@chiaberry chiaberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@roseeichelmann roseeichelmann merged commit 5cf0b7b into mike/21794_show_ecapris_statuses Jul 2, 2025
@roseeichelmann roseeichelmann deleted the rose/22702_disable_ecapris_filter branch July 2, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants