Disable eCAPRIS Notes Filter#1620
Conversation
johnclary
left a comment
There was a problem hiding this comment.
I followed the test steps and they checked out. Code looks great 🚢 🚢 🚢 🚢
mddilley
left a comment
There was a problem hiding this comment.
Works great! Thanks for taking care of this last piece of the puzzle. 🧩 🙏 🚢
| }) => { | ||
| return ( | ||
| <Tooltip title={isDisabled ? disabledMessage : ""}> | ||
| <span> |
There was a problem hiding this comment.
This was a TIL for me that tooltips won't show on disabled buttons since user interactions don't trigger on them. Could you add a comment or link to the docs here to help us avoid an accidental regression / deletion of that important span? 🙏
There was a problem hiding this comment.
+1, I could definitely see future me deleting this span that is silently doing so much work here
There was a problem hiding this comment.
ahh thanks for reminding me to comment about this! i meant to :))
Associated issues
Closes cityofaustin/atd-data-tech#22702
Testing
URL to test:
Local
Steps to test:
Ship list
[ ] Product manager added to QA test script if applicable