Skip to content

Add Bike/Ped counter component and CPRG project tags#1725

Merged
chiaberry merged 1 commit into
mainfrom
chia/25667-add-tags
Dec 3, 2025
Merged

Add Bike/Ped counter component and CPRG project tags#1725
chiaberry merged 1 commit into
mainfrom
chia/25667-add-tags

Conversation

@chiaberry
Copy link
Copy Markdown
Member

@chiaberry chiaberry commented Dec 2, 2025

Associated issues

cityofaustin/atd-data-tech#25667

Testing

local

Steps to test:

Apply migrations.

in the app, navigate to a project's map tab. Add a new component and see that Counter is an option, with the work types "new" "modification" "maintenace/repair" as options.
Screenshot 2025-12-02 at 7 48 57 AM

Go to a project's summary page and add a new tag, put CPRG in the autocomplete and see the new tags as options.

alternately:

select * from moped_components mct where component_name = 'Counter'
select * from moped_component_work_types mcwt where component_id = 168

but replace the component_id with the id from your component in the first one. You should get three records with work type ids of 5, 6 and 7.


Ship list

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 2, 2025

Deploy Preview for atd-moped-main ready!

Name Link
🔨 Latest commit 8fb16d7
🔍 Latest deploy log https://app.netlify.com/projects/atd-moped-main/deploys/692eefcc2a71c00008ecc75a
😎 Deploy Preview https://deploy-preview-1725--atd-moped-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@chiaberry chiaberry changed the title add cprg tags and ped counter component Add Bike/Ped counter component and CPRG project tags Dec 2, 2025
Copy link
Copy Markdown
Collaborator

@mddilley mddilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and this looks great! Thanks for adding, and TDM will be happy to have these available! 😎 🚢

'Bike/Ped',
FALSE,
5
WHERE NOT EXISTS (
Copy link
Copy Markdown
Collaborator

@mddilley mddilley Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw this reminded me to check with our robot friends about how we've been managing migrations for lookup values, and I came away with points that I think fit with what we've been doing so far:

  • create "real" down migrations when changing schema or existing data
  • not as important when adding lookup values since we can soft-delete later to phase out
  • our local stack using prod data that tracks what migrations are applied already has generally kept us away from migration conflicts when releasing (i can only think of one time where we've had to manually handle migrations when releasing)

the one suggestion from the chat was trying to use syntax like this WHERE NOT EXISTS to make them idempotent so that, if we had to run the no-op down migration, we could run the up migration again without running into conflicts or re-creating things.

i don't think we need to change anything in this PR but wanted to check in with the team if we feel strongly about changing our practice in the future

Copy link
Copy Markdown
Contributor

@roseeichelmann roseeichelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test steps worked as expected ✔️

@chiaberry chiaberry merged commit cccced4 into main Dec 3, 2025
5 checks passed
@chiaberry chiaberry deleted the chia/25667-add-tags branch December 16, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants