Attach new files to Moped funding records by chiaberry · Pull Request #1824 · cityofaustin/atd-moped

chiaberry · 2026-04-20T18:58:09Z

Associated issues

Testing

URL to test:
test locally, use prod data

Steps to test:

This PR builds off of the work in #1820

Open a project (or create a new one)
Navigate to the funding table. Select an eCAPRIS subproject id like 10553.009
Like the previous PR, you see funding rows, paperclip icons and Files column.
Now either add another funding row (not imported from eCAPRIS) or edit an existing row so the record is not synced from eCAPRIS.
Click the paperclip to open the attachment dialog.
Toggle the link to file switch and enter a name, type, description and a drive path or link.
You can see the file in the files column of this table, also go to the Files tab and see it there as well.
use your db client to confirm that this record is in the correct table.

select * from files_project_funding fpf

Click the paperclip to open the attached files dialog again. Now unlink the file.
The file is still on the Files tab but is no longer on the funding table.

Ship list

Code reviewed
Product manager approved
Product manager checked DB view dependencies
Product manager checked if any columns in views used by the Power BI dataflow were added, deleted, or renamed
Product manager added to QA test script if applicable
- Added items to launch checklist in [Collector] Attach files to eCAPRIS funding #1820

netlify · 2026-04-20T18:58:15Z

❌ Deploy Preview for atd-moped-main failed. Why did it fail? →

Name	Link
🔨 Latest commit	`737b224`
🔍 Latest deploy log	https://app.netlify.com/projects/atd-moped-main/deploys/69e6774525169600084ecd2b

…nding-file-attachments

mddilley

Looking great, Chia! Cool to see that the branching between the eCAPRIS and Moped records isn't bad at all imo. 😎 I found a small bug, but I was able to patch, test, and see attachments to both records types. 🙌

I'll come back and wrap the review once you've had a chance to look at the one comment.

frankhereford

When I get to step 4 in the testing instructions, "Now either add another funding row (not imported from eCAPRIS) or edit an existing row so the record is not synced from eCAPRIS.", when I submit that form, I get the following trapped error:

field 'moped_funding_files' not found in type: 'moped_proj_funding_insert_input'

I think the field may be missing from the gridRecord assignment on line 110 of the ProjectFunding helpers.js file.

I think this is a blocker on testing, and I will come back to this PR after dev sync today when I can ask about what you think about these findings.

Thanks for this PR Chia!! I feel rusty reviewing moped, so if I'm just out in left field, lmk and i'll do whatever I am missing. Thanks!

mddilley

I tested this every which way that I could, and I was able to attach and detach files to both eCAPRIS and Moped funding records. ✨ Thanks and this also helped me catch a small bug that I introduced into the local stack activity log that I'll PR shortly. 🚢 🙌 🚢

mddilley · 2026-04-29T18:23:22Z

@chiaberry I was reviewing issues today, and I realized that I missed scoping the detail of clearing Moped funding file attachments when the file itself is soft-deleted. So, I created cityofaustin/atd-data-tech#28174 to capture in future work.

Charlie-Henry · 2026-05-01T16:23:49Z

I got the same error as @frankhereford

chiaberry · 2026-05-04T19:14:10Z

@Charlie-Henry I tried running through the test steps again and couldnt replicate the error. did it happen on a new empty project, or was it on an existing project?

johnclary

I tested this heavily and it works beautifully! Nice!

johnclary · 2026-05-05T14:45:08Z

+    entity_id int4 NOT NULL REFERENCES public.moped_proj_funding(proj_funding_id) ON DELETE RESTRICT ON UPDATE CASCADE,
+    file_id int4 NOT NULL REFERENCES public.moped_project_files(project_file_id) ON DELETE RESTRICT ON UPDATE CASCADE,
+    created_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    updated_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),


i can't remember how the updated_at timestamp is managed. is this missing a trigger?

i left this out of scope since we were only creating and hard-deleting records, but since I'm rolling the soft deletes into cityofaustin/atd-data-tech#28174 - i'll add this there too. that way we will be able to see when the soft-delete update happened on the attachment tables. 🙏

johnclary · 2026-05-05T15:14:10Z

+            : "moped_funding_files";
+          if (!row?.[filesType]) {
+            return;
+          }


This awkward accessor problem sorta hints to me that it could be nice to combine the two files arrays upstream (client side, or in a view?) so that you can simply map over them here.

Depending on where this functionality of arbitrary file-entity attachments is heading, it might be worth it now to make a project_files_view or whatever that organizes this data more cleanly for the app to consume it.

johnclary · 2026-05-05T15:17:55Z

Couple of impressions now that I'm seeing this modal for a second time:

The modal header has slightly different padding and is missing the close button (X) vis a vis the funding record edit modal.

I think it could be good to move the submit/cancel buttons to be immediately below the attach file form, to make it clear the attached files are not part of the form/action.

I wonder if moving the attached files to the top of the modal would make this slightly more intuitive 🤔

this is confirming a feeling that i've had that we could benefit from a reusable dialog component. this one is baked into the file upload dialog currently, and i felt friction when writing code in here that could be reduced by pulling out that dialog wrapper (along with keeping our dialogs looking similar across the board).

I'm going to aim to implement these suggestions in cityofaustin/atd-data-tech#27484

mateoclarke

Tested locally and looks good.

I was having a similar error that @Charlie-Henry and @frankhereford called out, but running hasura metadata apply seemed to resolve it for me.

mateoclarke · 2026-05-06T18:03:47Z

+    () => rows.find((row) => row.id === fileAttachmentId),
+    [rows, fileAttachmentId]
+  );
+  const isSyncedFromECapris = fundingRecord.is_synced_from_ecapris;


wondering here if fundingRecord could ever return null (maybe if the fileAttachmentId is stale) and could throw an error on line 43. Maybe add a guard like:

const isSyncedFromECapris = fundingRecord?.is_synced_from_ecapris ?? false;

chiaberry added 9 commits April 17, 2026 11:19

add new funding file table

c9ecdd3

add the down migration

2ae47a1

need entity id

f18208f

add in the metadata

2ab8c8f

add relationship to project files table

bbc3f0f

add the new mutations

e230a02

add the created by and updated by

607caff

add moped proj files to request

fc5f7cb

check which files type to show

737b224

chiaberry added the WIP Work in progress label Apr 20, 2026

chiaberry changed the base branch from main to mike/27387_ecapris_file_attachments April 20, 2026 18:58

chiaberry added 4 commits April 20, 2026 14:18

remove console logs

5148bad

forgot a dep

e085c2d

remove xtra space

dda4237

memoize the funding record definition

d533929

chiaberry removed the WIP Work in progress label Apr 21, 2026

chiaberry requested review from Charlie-Henry, frankhereford, johnclary, mateoclarke, mddilley, roseeichelmann and tillyw and removed request for johnclary and mddilley April 21, 2026 20:57

Merge branch 'mike/27387_ecapris_file_attachments' into chia/27483-fu…

a9e5416

…nding-file-attachments

mddilley reviewed Apr 24, 2026

View reviewed changes

Comment thread moped-editor/src/views/projects/projectView/ProjectFunding/helpers.js

frankhereford reviewed Apr 27, 2026

View reviewed changes

chiaberry added 2 commits April 27, 2026 10:18

return nothing if no files types

da44063

add file attachment click for totally manual records

52ee5c6

chiaberry requested review from frankhereford and mddilley and removed request for mddilley April 27, 2026 15:50

mddilley approved these changes Apr 27, 2026

View reviewed changes

johnclary approved these changes May 5, 2026

View reviewed changes

mateoclarke approved these changes May 6, 2026

View reviewed changes

Conversation

chiaberry commented Apr 20, 2026 • edited by mddilley Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Associated issues

Testing

Ship list

Uh oh!

netlify Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for atd-moped-main failed. Why did it fail? →

Uh oh!

mddilley left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

frankhereford left a comment

Choose a reason for hiding this comment

Uh oh!

mddilley left a comment

Choose a reason for hiding this comment

Uh oh!

mddilley commented Apr 29, 2026

Uh oh!

Charlie-Henry commented May 1, 2026

Uh oh!

chiaberry commented May 4, 2026

Uh oh!

johnclary left a comment

Choose a reason for hiding this comment

Uh oh!

johnclary May 5, 2026

Choose a reason for hiding this comment

Uh oh!

mddilley May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnclary May 5, 2026

Choose a reason for hiding this comment

Uh oh!

johnclary May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mddilley May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateoclarke left a comment

Choose a reason for hiding this comment

Uh oh!

mateoclarke May 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chiaberry commented Apr 20, 2026 •

edited by mddilley

Loading

netlify Bot commented Apr 20, 2026 •

edited

Loading

mddilley May 5, 2026 •

edited

Loading

johnclary May 5, 2026 •

edited

Loading

mddilley May 5, 2026 •

edited

Loading