Skip to content

Conversation

@edgarrmondragon edgarrmondragon changed the title Support Poetry projects that use PEP 621 Support Poetry 2.0 and projects that use PEP 621 Oct 8, 2024
@edgarrmondragon edgarrmondragon changed the title Support Poetry 2.0 and projects that use PEP 621 Support Poetry 2.0 and PEP 621 Oct 8, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 5, 2025 19:55
@johnthagen
Copy link
Contributor

@edgarrmondragon Not sure if it should be in this PR or not, but for Poetry 2.0+ we should add the following configuration to the README

[tool.poetry.requires-plugins]
poetry-plugin-export = ">=1.8"

This fixes #874 and will ensure the export plugin is available for nox-poetry

@edgarrmondragon
Copy link
Collaborator Author

edgarrmondragon commented Jan 10, 2025

@edgarrmondragon Not sure if it should be in this PR or not, but for Poetry 2.0+ we should add the following configuration to the README

[tool.poetry.requires-plugins]
poetry-plugin-export = ">=1.8"

This fixes #874 and will ensure the export plugin is available for nox-poetry

* https://python-poetry.org/blog/announcing-poetry-2.0.0/#project-plugins-and-forcing-a-minimum-poetry-version

I don't think that's within the scope of this PR, since Poetry is not a direct dependency, but rather an external tool expected to already be installed and available in PATH.

This project should probably do that after upgrading to use 2.0 for itself, which this PR doesn't address. In the meantime, this project should probably add guidance in the readme/docs for projects that use Poetry 2.0+.

@johnthagen
Copy link
Contributor

In the meantime, this project should probably add guidance in the readme/docs for projects that use Poetry 2.0+.

Yeah, sorry that's what I meant.

@johnthagen
Copy link
Contributor

@edgarrmondragon I opened

@cjolowicz cjolowicz merged commit 53062d9 into cjolowicz:main Jan 10, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants