Skip to content

Update bitflags 0.8.0 -> 0.9 #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kbknapp merged 1 commit into from
Jun 10, 2017
Merged

Update bitflags 0.8.0 -> 0.9 #966

kbknapp merged 1 commit into from
Jun 10, 2017

Conversation

@golem131
Copy link
Contributor

@golem131 golem131 commented May 22, 2017 •
edited by kbknapp
Loading

This change is Reviewable

@mention-bot
Copy link

mention-bot commented May 22, 2017

@golem131, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp, @crazymerlyn and @japaric to be potential reviewers.

@coveralls
Copy link

coveralls commented May 22, 2017

Coverage Status

Coverage increased (+0.3%) to 92.141% when pulling 49896f7 on golem131:dependency_update into 2923515 on kbknapp:master.

@kbknapp
Copy link
Member

kbknapp commented May 22, 2017

Looks like unicode-segmentation updated their minimum required version of Rust by using ?

@homu
Copy link
Contributor

homu commented May 29, 2017

☔ The latest upstream changes (presumably 53c1ffe) made this pull request unmergeable. Please resolve the merge conflicts.

@kbknapp
Copy link
Member

kbknapp commented May 29, 2017

@golem131 can you rebase onto the latest master and this should be good for a merge 😉

@golem131 golem131 force-pushed the dependency_update branch from 49896f7 to 2c96b2d Compare May 31, 2017 09:55
@golem131
Copy link
Contributor Author

golem131 commented May 31, 2017

@kbknapp - fixed

@coveralls
Copy link

coveralls commented May 31, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 91.927% when pulling 2c96b2d on golem131:dependency_update into 49f9dc1 on kbknapp:master.

@kbknapp
Copy link
Member

kbknapp commented May 31, 2017

Thanks! @homu r+

@homu
Copy link
Contributor

homu commented May 31, 2017

📌 Commit 2c96b2d has been approved by kbknapp

homu added a commit that referenced this pull request May 31, 2017
@homu
Auto merge of #966 - golem131:dependency_update, r=kbknapp
9a407be 
Update bitflags 0.8.0 -> 0.9

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/kbknapp/clap-rs/966)
<!-- Reviewable:end -->
@homu
Copy link
Contributor

homu commented May 31, 2017

⌛ Testing commit 2c96b2d with merge 9a407be...

@homu
Copy link
Contributor

homu commented May 31, 2017

💥 Test timed out

@brson
Copy link

brson commented Jun 6, 2017

Oh I was just about to do this myself. Ping @kbknapp

@brson brson mentioned this pull request Jun 6, 2017
Closed
@budziq budziq mentioned this pull request Jun 7, 2017
Merged
4 tasks
@budziq
Copy link

budziq commented Jun 7, 2017 •
edited
Loading

Hi @kbknapp,

Thanks for the merge! Would you be willing to make a release to crates.io? It would help is with a build break in rust-cookbook.

I would be willing to make any required changes in a PR. Thanks for your time 😃!

cc https://github.com/brson/rust-cookbook/pull/192

@kbknapp kbknapp merged commit 77763e1 into clap-rs:master Jun 10, 2017
This was referenced Jun 19, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@golem131 @mention-bot @coveralls @kbknapp @homu @brson @budziq