Simple question parsing. #2
Conversation
| @@ -63,7 +64,7 @@ private TceClassPageParser(Document page) { | |||
| STATE_READING_RESULTS, | |||
| } | |||
|
|
|||
| private TceClassProto buildModel() { | |||
| private TceClassProto buildModel() throws ParseException { | |||
There was a problem hiding this comment.
I'm not a fan of needing "throws" declarations---they end up being awkward to use due to language requirements. I think your implementation re-throwing it a couple levels and then ending up with a printStackTrace and a TODO is evidence of it being an "anti-pattern". Unfortunately, ParseException is an Exception and not a RuntimeException, so the language leaves you no choice (again, "anti-pattern").
How do you feel about just throwing it as a RuntimeException (to avoid the language shenanigans)? Then later, for proper handling, we can install a few high-level exception handlers: e.g. an Exception caught while doing downloading/parsing of all the pages could gracefully retry (for something like a network failure) or forcefully exit (for a deterministic parsing failure), while a frontend failure while serving the site should be logged but not bring down the server.
No description provided.